[Kde-pim] Review Request 111507: Add CHANGEDSINCE parameter to FETCH command

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111507/#review36019
-----------------------------------------------------------

Ship it!


Looks good to me, thanks!


server/src/handler/fetchhelper.cpp
<http://git.reviewboard.kde.org/r/111507/#comment26653>

    you can probably replace parseTimestamp() with mStreamParser->readNumber(), which does essentially the same.


- Volker Krause


On July 14, 2013, 9:55 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111507/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 9:55 p.m.)
> 
> 
> Review request for Akonadi, Vishesh Handa and Volker Krause.
> 
> 
> Description
> -------
> 
> This allows clients to fetch from the Akonadi server only those items that have been changed since given timestamp. The syntax is CHANGEDSINCE %unixTimestamp%.
> 
> Usecase for this feature is mainly in the Nepomuk Feeder agent, which currently has to fetch all items from Akonadi and all items from Nepomuk on start up and compare them, to make sure the Nepomuk database is in sync with Akonadi. It causes high IO and high CPU and memory consumption during start, slowing down the start up. This feature will allow the Feeder to request only items that have changed since last time, which in most cases should mean no items at all.
> 
> 
> Diffs
> -----
> 
>   libs/protocol_p.h e94bf94 
>   server/src/akonadiconnection.cpp b8bcca3 
>   server/src/handler/fetchhelper.h 7f0f2b7 
>   server/src/handler/fetchhelper.cpp 78ea6ed 
>   server/src/handlerhelper.h 294b128 
>   server/src/handlerhelper.cpp e6d2f51 
> 
> Diff: http://git.reviewboard.kde.org/r/111507/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/