[Kde-pim] Review Request 111755: Fix, update and re-enable IMAP resource unit-tests

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111755/#review36784
-----------------------------------------------------------

Ship it!


Looks good to me.

For the record, in case of renames you can use --find-copies-harder in case of file renames to have them appear properly on review board.

- Kevin Ottens


On July 30, 2013, 5:19 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111755/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 5:19 a.m.)
> 
> 
> Review request for KDEPIM and Kevin Ottens.
> 
> 
> Description
> -------
> 
> 1) makes the tests compile
> 2) adds a new abstraction that allows us to move Akonadi::ItemFetchJob from RetrieveItemsTask to ImapResource and replace it by a dummy Job in unittests
> 3) fixes MoveItemsTask to pass tests
> 4) updates all unittests to pass (changed behavior in tasks)
> 
> For TestMoveItemsTask to pass, a patch in KIMAP is needed (will post in a new review)
> 
> 
> Diffs
> -----
> 
>   resources/imap/CMakeLists.txt 6498129 
>   resources/imap/imapresource.h 83f6325 
>   resources/imap/imapresource.cpp 0128eed 
>   resources/imap/moveitemstask.cpp 5dc7021 
>   resources/imap/resourcestate.h 87e9811 
>   resources/imap/resourcestate.cpp 5d521a5 
>   resources/imap/resourcestateinterface.h 7bfe5a3 
>   resources/imap/resourcetask.h 4a121fb 
>   resources/imap/resourcetask.cpp ce780cb 
>   resources/imap/retrieveitemstask.h a3ba234 
>   resources/imap/retrieveitemstask.cpp c82d465 
>   resources/imap/tests/dummyresourcestate.h eb4b2ef 
>   resources/imap/tests/dummyresourcestate.cpp d1e4e29 
>   resources/imap/tests/testaddcollectiontask.cpp c8816d3 
>   resources/imap/tests/testmoveitemtask.cpp 3bf67b2 
>   resources/imap/tests/testremoveitemtask.cpp 0e61135 
>   resources/imap/tests/testretrieveitemstask.cpp b542423 
> 
> Diff: http://git.reviewboard.kde.org/r/111755/diff/
> 
> 
> Testing
> -------
> 
> All tests pass
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/