[Kde-pim] Review Request 111542: Support only filename for external payload files

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111542/#review36065
-----------------------------------------------------------

Ship it!


Looks good, just some minor comments. Thanks!


akonadi/itemserializer.cpp
<http://git.reviewboard.kde.org/r/111542/#comment26723>

    QFileInfo::isAbsolute() instead maybe? assuming no path separators is an unnecessary limitation I think, if we ever need to organize the file data folder with sub-folders (to support a file system that doesn't perform with a few 100k files in the same folder for example).



akonadi/itemserializer.cpp
<http://git.reviewboard.kde.org/r/111542/#comment26724>

    why QLatin1Char('/') here and QDir::separator() below?


- Volker Krause


On July 16, 2013, 9:29 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111542/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 9:29 p.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Client-side part of https://git.reviewboard.kde.org/r/111541/
> 
> Announce capability to handle only filename, instead of full filepath to external payload file and actually handle it :)
> 
> 
> Diffs
> -----
> 
>   akonadi/itemserializer.cpp be5c263 
>   akonadi/session.cpp 8657692 
> 
> Diff: http://git.reviewboard.kde.org/r/111542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/