[Kde-pim] Review Request 111819: Fix creating items with a single external payload.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111819/#review36880
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On July 31, 2013, 6:51 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111819/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 6:51 p.m.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Description
> -------
> 
> Fix creating items with a single external payload.
> 
> This was removing the just inserted part from the db again, but keeping the
> external payload file around. This cannot possibly have ever worked...
> 
> We probably didn't notice this so far since emails are multi-part and don't
> hit this path at all, and everything else is usually too small for the
> external storage threshold. This was found by the unit tests for
> ItemCreateJob in kdepimlibs.
> 
> 
> Diffs
> -----
> 
>   server/src/handler/append.cpp f3bb77743f07e9bb15589749265cd27df536fcd0 
> 
> Diff: http://git.reviewboard.kde.org/r/111819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/