[Kde-pim] Review Request 111742: Renabled signature url for fingerprint lookup via kleopatra

[Lindsay Mathieson]

> On July 28, 2013, 5:34 p.m., Laurent Montel wrote:
> > messageviewer/viewer/objecttreeparser.cpp, line 2585
> > <http://git.reviewboard.kde.org/r/111742/diff/1/?file=173945#file173945line2585>
> >
> >     Perhaps you can add a testcase for testing it.
> >     (And how to use it)
> >     Thanks
> 
> Lindsay Mathieson wrote:
>     I'm afraid I don't know the first thing about test cases, or even how to use them. Or even what they are :) Any pointers?
> 
> Laurent Montel wrote:
>     How to show your feature for example ?:)
>     you implemented a patch but we don't know how to how result :)
> 
> Lindsay Mathieson wrote:
>     I presumed you meant something formal, such as a unit test - are you just meaning a description of how to use the functionality?
> 
> Laurent Montel wrote:
>     yes :)

Heh :)

I did fill in the "Testing Done" field that idicates how to invoke and test it, am I missing some other entry?


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111742/#review36625
-----------------------------------------------------------


On July 29, 2013, 8:21 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111742/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 8:21 p.m.)
> 
> 
> Review request for Akonadi and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Added a url to the signature html in the message display for looking up the signature fingerprint via the kleopatra keysearch dialog. This simplifies the verification and addition of public keys. 
> The url invokes kleopatra with the args "--query <fingerprint>"
> 
> 
> Diffs
> -----
> 
>   messageviewer/viewer/objecttreeparser.cpp 3d26ced38709a58b16823d47a21eaed19c4766b5 
> 
> Diff: http://git.reviewboard.kde.org/r/111742/diff/
> 
> 
> Testing
> -------
> 
> Viewed msgs with known and unknown signatures, using the signature link to invoke a vs of kleopatra that supports "--query" (see review 111741).
> Signature details were correctly found in kleopatra.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/