[Kde-pim] Review Request 111743: remove the confusion for ServiceType

[Volker Krause]

> On July 31, 2013, 7:51 a.m., Volker Krause wrote:
> > I don't understand the actual problem you are trying to fix here. Yes, the enums have different content on the server and client side, although they represent the same concept. But they are only used internally on the respective side (ie. the numeric representation is not used for communication), so the different numeric values don't matter, right?
> 
> Guy Maurel wrote:
>     I think: It matters!
>     
>     I am working on the bug "Once a month".
>     There I add some "kDebug() ..." to see what is happening.
>     And see each time the filtering doesn't work, that the variable "serverUpgrading" is TRUE, so the "if" makes a "return Upgrading": 
>     kdepimlibs/akonadi/servermanager.cpp:224
>       if ( serverUpgrading )
>         return Upgrading;
>     
>     Looking at the server which part of the server generates "Upgrading", I found it only occurs by a change of the version, not "Once a month".
>     The question I have: Which part is writting this value?

The upgrading state is communicated via a D-Bus service name. The server side is in server/src/storage/dbupdater.cpp:57, the client side checks this in pimlibs/akonadi/servermanager.cpp:223. The service name is relevant for the communication there, not the numeric value of the enum. Of course it's important both sides have the same understanding of the state, but what number this is mapped to would only be important if this number is shared directly between both sides.

You are right that the upgrading state should only occur if the server is actually performing changes on the database during startup, which should have happened only once in the past half year or so, more frequent occurrence sounds indeed like a bug.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111743/#review36857
-----------------------------------------------------------


On July 27, 2013, 1:59 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111743/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 1:59 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Kevin Krammer, Till Adam, and Volker Krause.
> 
> 
> Description
> -------
> 
> There is a confusion for the enum ServiceType.
> The file kdepimlibs/akonadi/servermanager.h defines 4 menbers.
> The file akonadi/shared/akdbus.h defines 6 members.
> 
> This gives a confusion for the value of UpgradeIndicator, in the first case it is 3, in the second case 5.
> 
> This leads to a error for the code at kdepimlibs/akonadi/servermanager.cpp:224
>   if ( serverUpgrading )
>     return Upgrading;
> 
> I propose an import from akonadi/shared/akdbus.h, which will better support the next changes.
> 
> 
> Diffs
> -----
> 
>   akonadi/agentbase.cpp acbacc3 
>   akonadi/agentinstance.cpp 8af5edc 
>   akonadi/agentmanager.cpp 03e4b1f 
>   akonadi/changenotificationdependenciesfactory.cpp a5d5cc0 
>   akonadi/entitytreemodel_p.cpp 039f4dc 
>   akonadi/selftestdialog.cpp 9231722 
>   akonadi/servermanager.h 4425395 
>   akonadi/servermanager.cpp 45ab8c3 
>   akonadi/session.cpp 2e78f94 
> 
> Diff: http://git.reviewboard.kde.org/r/111743/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/