[Kde-pim] Review Request 111742: Renabled signature url for fingerprint lookup via kleopatra

Laurent Montel montel at kde.org
Sun Jul 28 08:34:40 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111742/#review36625
-----------------------------------------------------------



messageviewer/viewer/objecttreeparser.cpp
<http://git.reviewboard.kde.org/r/111742/#comment27029>

    if (....) {
    } else {



messageviewer/viewer/objecttreeparser.cpp
<http://git.reviewboard.kde.org/r/111742/#comment27030>

    Perhaps you can add a testcase for testing it.
    (And how to use it)
    Thanks


- Laurent Montel


On July 27, 2013, 9:28 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111742/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 9:28 p.m.)
> 
> 
> Review request for KDEPIM and Lindsay Mathieson.
> 
> 
> Description
> -------
> 
> Added a url to the signature html in the message display for looking up the signature fingerprint via the kleopatra keysearch dialog. This simplifies the verification and addition of public keys. 
> The url invokes kleopatra with the args "--query <fingerprint>"
> 
> 
> Diffs
> -----
> 
>   messageviewer/viewer/objecttreeparser.cpp 3d26ced 
> 
> Diff: http://git.reviewboard.kde.org/r/111742/diff/
> 
> 
> Testing
> -------
> 
> Viewed msgs with known and unknown signatures, using the signature link to invoke a vs of kleopatra that supports "--query" (see review 111741).
> Signature details were correctly found in kleopatra.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list