[Kde-pim] Review Request 111544: mixed maildir resource: don't use a few GB of memory when importing a big folder

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111544/#review36087
-----------------------------------------------------------


Awesome, thanks for taking care of that!


resources/mixedmaildir/retrieveitemsjob.h
<http://git.reviewboard.kde.org/r/111544/#comment26739>

    Maybe for consistency have a KJob* argument and just log the error if there is one.



resources/mixedmaildir/retrieveitemsjob.h
<http://git.reviewboard.kde.org/r/111544/#comment26740>

    same here


- Kevin Krammer


On July 17, 2013, 9:54 a.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111544/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 9:54 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Jobs were piling up too fast. This throttles job creation down and fixes the memory usage problem.
> 
> 
> Diffs
> -----
> 
>   resources/mixedmaildir/retrieveitemsjob.cpp 0218c22 
>   resources/mixedmaildir/retrieveitemsjob.h ce9e53b 
> 
> Diff: http://git.reviewboard.kde.org/r/111544/diff/
> 
> 
> Testing
> -------
> 
> Memory is stable.
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/