[Kde-pim] Review Request 111240: kmail-mobile: AccountsListPage

Michael Bohlender michael.bohlender at kdemail.net
Tue Jul 23 14:16:45 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111240/
-----------------------------------------------------------

(Updated July 23, 2013, 1:16 p.m.)


Review request for KDEPIM.


Changes
-------

fix the two code styling issues. I really need to pay more attention to this.


Description
-------

This is the base for the accounts list which will become the first page in the PageRow according to our mockup. 
It is just for navigation and wont replace the accounts settings page.
It does not make sense to activate this page until the other pages are ready.


Diffs (updated)
-----

  mobile/lib/AgentInstanceListDelegate.qml ef6b5c8 
  mobile/lib/AgentInstanceStatusIndicator.qml PRE-CREATION 
  mobile/lib/CMakeLists.txt 747d6ab 
  mobile/lib/qmldir 3b3814f 
  mobile/mail/AccountsPage.qml PRE-CREATION 
  mobile/mail/CMakeLists.txt cd823ad 

Diff: http://git.reviewboard.kde.org/r/111240/diff/


Testing
-------

Started, interacted with. but deactivated again.


Thanks,

Michael Bohlender

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list