[Kde-pim] Review Request 111458: kmail-mobile: rework headerlist

[Michael Bohlender]

> On July 9, 2013, 3:46 p.m., Kevin Krammer wrote:
> > mobile/mail/HeaderView.qml, line 22
> > <http://git.reviewboard.kde.org/r/111458/diff/1/?file=169585#file169585line22>
> >
> >     Hmm, didn't you keep the "as QML" part in other files?

Styling guide says "QtQuick 1.1" I did not change it in the other files (yet)


> On July 9, 2013, 3:46 p.m., Kevin Krammer wrote:
> > mobile/mail/HeaderView.qml, line 53
> > <http://git.reviewboard.kde.org/r/111458/diff/1/?file=169585#file169585line53>
> >
> >     I know this is just moved, but maybe rename to something that does not start with an underscore? underscore usually hints that this is an object exported from C++ as a context property

will do


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111458/#review35793
-----------------------------------------------------------


On July 9, 2013, 10:12 a.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111458/
> -----------------------------------------------------------
> 
> (Updated July 9, 2013, 10:12 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Port headerlist away from KPIM.ItemList(delegate). This is necessary to make it a standalone page that can push other pages.
> Port headerlist to plasmacomponents. (only what is needed stays)
> Removes BulkActionComponent.
> Removes headerlist configuration options.
> 
> The mail status icons get removed for now. the will probably by replaced by a single mailstatus icon/button. needs some changing in the proxymodel first.
> The idea is to give the model an entry "mailStatus" that contains the status as an icon name (new/unread/read/important/replied/forwarded...) Is that a good approach? We will probably keep the old attachmethey are currently not working though. nt/signed/encrypted status icons.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/BulkActionComponent.qml 748f80d 
>   mobile/mail/CMakeLists.txt 49785d9 
>   mobile/mail/HeaderView.qml 9aab53e 
>   mobile/mail/KMailActions.qml a146031 
>   mobile/mail/StartPage.qml 9df5092 
>   mobile/mail/configwidget.cpp 82e3490 
>   mobile/mail/configwidget.ui 955a48a 
> 
> Diff: http://git.reviewboard.kde.org/r/111458/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/