[Kde-pim] Review Request 111482: kmail-mobile: enable page based layout

[Michael Bohlender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111482/
-----------------------------------------------------------

(Updated July 18, 2013, 10:25 a.m.)


Review request for KDEPIM.


Changes
-------

correct code styling for onCurrent.. and onPress.. in kmail-mobile


Description
-------

Initializes the pagebased layout. We can do this now because master does not need to be in a releasable state. But I could also do this in a feature branch.

Adds a FolderPage
This page is just reusing AkonadiBreadcrumbNavigationView and a placeholder for the FavoriteFolder Page and the Accounts Page.
For now there is a stupid Next-button to get to the next page. it will obviously go away once we have the actual FavoriteFolder page.

Adds a MailListPage
We will need to merge MailListPage and HeaderView so we can push the MailViewPage form the list and not with the stupid button on the toolbar.

The MailListPage will only display a blank page for now. Will get fixed  when we merge MailListPage with HeaderView.


Diffs (updated)
-----

  mobile/mail/AboutPage.qml b7e460e 
  mobile/mail/AccountSettingsPage.qml 3cef3bf 
  mobile/mail/AclEditor.qml a1d96f7 
  mobile/mail/AttachmentEditor.qml 5acb03a 
  mobile/mail/CMakeLists.txt b56a722 
  mobile/mail/ConfigDialog.qml 24794f1 
  mobile/mail/EditorView.qml f8fe063 
  mobile/mail/FavoriteManagerPage.qml f83c6cd 
  mobile/mail/FilterEditor.qml 95a6eb8 
  mobile/mail/FolderPage.qml PRE-CREATION 
  mobile/mail/ForwardOptionsPage.qml 887d501 
  mobile/mail/HeaderView.qml ca94fa8 
  mobile/mail/KMailActions.qml ee14d06 
  mobile/mail/MailListPage.qml PRE-CREATION 
  mobile/mail/MailViewPage.qml 0d6acb7 
  mobile/mail/MarkAsPage.qml bcf35e9 
  mobile/mail/NewMailPage.qml 13ed36e 
  mobile/mail/ReplyOptionsPage.qml bb54bee 
  mobile/mail/SettingsPage.qml 957076a 
  mobile/mail/SnippetsEditor.qml 07ed894 
  mobile/mail/StartPage.qml 39d0291 
  mobile/mail/kmail-mobile.qml 1eba3ec 

Diff: http://git.reviewboard.kde.org/r/111482/diff/


Testing
-------

selected a folder, selected an email, hit "reply button" and got the right text quoted in the composer


Thanks,

Michael Bohlender

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/