[Kde-pim] Review Request 111741: Implements --query command

[Kevin Krammer]

> On July 27, 2013, 2:46 p.m., Kevin Krammer wrote:
> > kleopatra/commands/lookupcertificatescommand.cpp, line 189
> > <http://git.reviewboard.kde.org/r/111741/diff/1/?file=173942#file173942line189>
> >
> >     as far as I can tell from other occurences the style for checking pointer is to use their boolean duality, i.e. if ( findEd &&...
> 
> Lindsay Mathieson wrote:
>     I was taught as a boy (long time ago ...) that assuming NULL was zero (false) on all platforms was a bad assumption, happy to assume it for KDE though if thats safe.

Ideally the check would be != 0, or != nullptr in C++11
However it seems the style of the file is to use the pointer/integer/boolean duality (I wish there was a way get compiler warning/error for that)
NULL is almost always wrong in C++. being a preprocessor macro there is no way of ensuring it is defined to 0.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111741/#review36600
-----------------------------------------------------------


On July 29, 2013, 9:44 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111741/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 9:44 a.m.)
> 
> 
> Review request for Akonadi, Lindsay Mathieson and Volker Krause.
> 
> 
> Description
> -------
> 
> Added support for "--query <fingerprint>" command. Pre-loads search field and starts default keyserver search.
> 
> 
> This addresses bug 175980.
>     http://bugs.kde.org/show_bug.cgi?id=175980
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/lookupcertificatescommand.h 80215fd47caa2e71772288cec3718f9773fb6c71 
>   kleopatra/commands/lookupcertificatescommand.cpp 289d322c1b515663ce8a2a9ef1645b1744c637de 
>   kleopatra/dialogs/lookupcertificatesdialog.h b8fa78f4b7efb14940809e2cf1f0d7184db9f525 
>   kleopatra/dialogs/lookupcertificatesdialog.cpp b50bcd4ab99491f9d526a6b4349c1a5f1aae698f 
>   kleopatra/kleopatraapplication.h 202c937eb2c3ede6fe357baee42336f45ffe545b 
>   kleopatra/kleopatraapplication.cpp b39c0e50ad6dedf08029e66a3f4ba4102b1c9d58 
> 
> Diff: http://git.reviewboard.kde.org/r/111741/diff/
> 
> 
> Testing
> -------
> 
> Started kleopatra from console with various options such as:
> 
>   kleopatra --query 04b8b187
> 
> Keysearch dialog is displayed with correct parameters.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/