[Kde-pim] Review Request 110647: Gid support for akonadi

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110647/#review36021
-----------------------------------------------------------

Ship it!


Found some possible optimizations, looks good otherwise, thanks!


server/src/handler/fetchhelper.cpp
<http://git.reviewboard.kde.org/r/110647/#comment26654>

    maybe only send this if it's not empty, to not bloat the result for items that don't use GIDs?



server/src/storage/akonadidb.xml
<http://git.reviewboard.kde.org/r/110647/#comment26655>

    should probably be indexed


- Volker Krause


On June 1, 2013, 6:55 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110647/
> -----------------------------------------------------------
> 
> (Updated June 1, 2013, 6:55 p.m.)
> 
> 
> Review request for Akonadi and Volker Krause.
> 
> 
> Description
> -------
> 
> Support for Gid (globally unique identifier).
>     
> This patch adds a new table for the gid of an item.
> Support for:
> * append commands
> * store command
> * fetch command
>     
> Cleanup of gid table works via ON DELETE CASCADE
> 
> 
> Diffs
> -----
> 
>   libs/protocol_p.h e94bf943bf5ffd36378d12176e55732f5acaee63 
>   server/src/akonadiconnection.cpp b8bcca36b33bd9f7739bc1d0a12e724c0b825f30 
>   server/src/handler/akappend.cpp 9011b9572a35669a97d1433bfb9b5132416617fe 
>   server/src/handler/append.cpp ceac8bd0f7e1ef41b4fbb6ae67bd7f5a0c29abd0 
>   server/src/handler/copy.cpp 2483b378e8a0dceba12cb04bf6b332822909eb63 
>   server/src/handler/fetch.cpp 8c6b2b478f3bdbc2d1489409d426ef26fdb68bc1 
>   server/src/handler/fetchhelper.cpp 78ea6edcb12517a186b1f2e1f2e7f6a8a15306af 
>   server/src/handler/scope.h f2fefb0c2e27e27945b6d1074ae0a11f82ee4e2f 
>   server/src/handler/scope.cpp fe4ad885ede634565b3494344568b7e91ca13877 
>   server/src/handler/store.h 64a8683748c1f2132a7c7717c13c157dd57d8449 
>   server/src/handler/store.cpp d1d9b4efa190952b1ec2bfc768c0369853b40f81 
>   server/src/storage/akonadidb.xml 4a560ac44f52062562c40605c8f9e2ca7173ae31 
>   server/src/storage/datastore.h bac94b7cd7de87fe043b469cd01c6b6e28d9d4fb 
>   server/src/storage/datastore.cpp f5a1bc6710e84f35ec0da691f11b34d032a80c76 
>   server/src/storage/itemqueryhelper.h 08d2a85afd18894c72b4ca0cb6b82238d1b11c9a 
>   server/src/storage/itemqueryhelper.cpp 15b5774bf5b68834ae2f2f7ee164f1297c0a92f5 
>   server/tests/unittest/scopetest.cpp c6c720c9438b1fd65d30dc340920d85ca1555f7e 
> 
> Diff: http://git.reviewboard.kde.org/r/110647/diff/
> 
> 
> Testing
> -------
> 
> tests in kdepimlibs
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/