[Kde-pim] Review Request 111741: Implements --query command

[Lindsay Mathieson]

> On July 27, 2013, 11:48 p.m., Milian Wolff wrote:
> > kleopatra/commands/lookupcertificatescommand.cpp, line 188
> > <http://git.reviewboard.kde.org/r/111741/diff/1/?file=173942#file173942line188>
> >
> >     this is very ugly. Refactoring the dialog would silently break this if e.g. the name changed. I'd say rather add the required API to the dialog and make this an explicit feature.

Agree, just didn't want to fiddle with other peoples code. Will fix.


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111741/#review36594
-----------------------------------------------------------


On July 27, 2013, 11:14 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111741/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 11:14 p.m.)
> 
> 
> Review request for KDEPIM and Volker Krause.
> 
> 
> Description
> -------
> 
> Added support for "--query <fingerprint>" command. Pre-loads search field and starts default keyserver search.
> 
> 
> This addresses bug 175980.
>     http://bugs.kde.org/show_bug.cgi?id=175980
> 
> 
> Diffs
> -----
> 
>   kleopatra/commands/lookupcertificatescommand.h 80215fd 
>   kleopatra/commands/lookupcertificatescommand.cpp 289d322 
>   kleopatra/kleopatraapplication.h 202c937 
>   kleopatra/kleopatraapplication.cpp b39c0e5 
> 
> Diff: http://git.reviewboard.kde.org/r/111741/diff/
> 
> 
> Testing
> -------
> 
> Started kleopatra from console with various options such as:
> 
>   kleopatra --query 04b8b187
> 
> Keysearch dialog is displayed with correct parameters.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/