[Kde-pim] Review Request 111467: kmail-mobile: initial mailviewpage

[Michael Bohlender]

> On July 9, 2013, 3:49 p.m., Kevin Krammer wrote:
> > mobile/mail/MailViewPage.qml, line 67
> > <http://git.reviewboard.kde.org/r/111467/diff/1/?file=169704#file169704line67>
> >
> >     doesn't this unnecessarily increase the margin when the view becomes wider?

that is exactly the point. the initial page will take 2/3 of the screen and eventual shrink to 1/3. a fixed margin would be to big for the 1/3 version.

I was told by the plasma active devs that I should always use relational and not pixel based layouts with qml because they might behave bad on future screens with insanely high pixel density.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111467/#review35794
-----------------------------------------------------------


On July 9, 2013, 2:49 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111467/
> -----------------------------------------------------------
> 
> (Updated July 9, 2013, 2:49 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> creates the initial mailviewpage with some actions.
> this is not yet accessible from the ui.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/CMakeLists.txt 49785d9 
>   mobile/mail/MailViewPage.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/