[Kde-pim] Review Request 111526: Added function to determine weekdays in Calendar

[Heena Mahour]

> On July 15, 2013, 4:29 p.m., Sergio Luis Martins wrote:
> > Please use KCalendarSystem functions instead. kdepim has to support non gregorian calendars
> 
> Mark Gaiser wrote:
>     Hi Sergio, are you sure about that? It's my intention to make/finish these components with an eye on the future as in Qt 5.2 or so. A future where the KCalendar stuff is merged into Qt (that is ICU right?). So that's why i initially started using QDate classes with the impression that those would automatically support the calendars that KDE supports since that was the plan.
>     
>     I don't know what the current state of that idea is, perhaps you could elaborate on that? All i can find is: http://qt-project.org/wiki/Qt-5-ICU

I think for the time being QDate is fine here since with KCalendarSystem ,plasmoidviewer is crashing here though with QDate it works fine .I will go with Mark for the tie being. 


- Heena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111526/#review35985
-----------------------------------------------------------


On July 15, 2013, 4:20 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111526/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 4:20 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries, Mark Gaiser, and Marco Martin.
> 
> 
> Description
> -------
> 
> The day names will be localized according to the system's default locale settings.
> 
> 
> Diffs
> -----
> 
>   qml/calendar/calendar.h 46f4e4e 
>   qml/calendar/calendar.cpp c7ffe12 
> 
> Diff: http://git.reviewboard.kde.org/r/111526/diff/
> 
> 
> Testing
> -------
> 
> Testing : Done
> Works well with QML .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/