[Kde-pim] Review Request 111482: kmail-mobile: enable page based layout
Michael Bohlender
michael.bohlender at kdemail.net
Mon Jul 15 16:36:57 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111482/
-----------------------------------------------------------
(Updated July 15, 2013, 3:36 p.m.)
Review request for KDEPIM.
Changes
-------
Merge HeaderView into MailListPage.
Use PageRow instead of PageStack as the base Layout and adjust every Page accordingly.
Description
-------
Initializes the pagebased layout. We can do this now because master does not need to be in a releasable state. But I could also do this in a feature branch.
Adds a FolderPage
This page is just reusing AkonadiBreadcrumbNavigationView and a placeholder for the FavoriteFolder Page and the Accounts Page.
For now there is a stupid Next-button to get to the next page. it will obviously go away once we have the actual FavoriteFolder page.
Adds a MailListPage
We will need to merge MailListPage and HeaderView so we can push the MailViewPage form the list and not with the stupid button on the toolbar.
The MailListPage will only display a blank page for now. Will get fixed when we merge MailListPage with HeaderView.
Diffs (updated)
-----
mobile/mail/AboutPage.qml b7e460e
mobile/mail/AccountSettingsPage.qml 3cef3bf
mobile/mail/CMakeLists.txt b56a722
mobile/mail/FavoriteManagerPage.qml f83c6cd
mobile/mail/FilterEditor.qml 95a6eb8
mobile/mail/FolderPage.qml PRE-CREATION
mobile/mail/ForwardOptionsPage.qml 887d501
mobile/mail/HeaderView.qml ca94fa8
mobile/mail/KMailActions.qml ee14d06
mobile/mail/MailListPage.qml PRE-CREATION
mobile/mail/MailViewPage.qml 0d6acb7
mobile/mail/MarkAsPage.qml bcf35e9
mobile/mail/NewMailPage.qml 13ed36e
mobile/mail/ReplyOptionsPage.qml bb54bee
mobile/mail/SettingsPage.qml 957076a
mobile/mail/StartPage.qml 39d0291
mobile/mail/kmail-mobile.qml 1eba3ec
Diff: http://git.reviewboard.kde.org/r/111482/diff/
Testing
-------
selected a folder, selected an email, hit "reply button" and got the right text quoted in the composer
Thanks,
Michael Bohlender
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list