[Kde-pim] Review Request 111482: kmail-mobile: enable page based layout

[Michael Bohlender]

> On July 15, 2013, 5:52 p.m., Kevin Krammer wrote:
> > mobile/mail/FolderPage.qml, line 56
> > <http://git.reviewboard.kde.org/r/111482/diff/2/?file=170682#file170682line56>
> >
> >     just curious, where does that 7 come from?

it was this way in StartPage.qml so that it always displays 7 entries at a time


> On July 15, 2013, 5:52 p.m., Kevin Krammer wrote:
> > mobile/mail/MailListPage.qml, line 79
> > <http://git.reviewboard.kde.org/r/111482/diff/2/?file=170686#file170686line79>
> >
> >     see comment about 7 earlier

i did not want theme to be the same height so that they don't align with the folders when both are displayed side by side. because the mails are in the folder the folder is visually bigger. 


> On July 15, 2013, 5:52 p.m., Kevin Krammer wrote:
> > mobile/mail/MailListPage.qml, line 92
> > <http://git.reviewboard.kde.org/r/111482/diff/2/?file=170686#file170686line92>
> >
> >     intendation?

fixed. 


> On July 15, 2013, 5:52 p.m., Kevin Krammer wrote:
> > mobile/mail/MailViewPage.qml, line 35
> > <http://git.reviewboard.kde.org/r/111482/diff/2/?file=170687#file170687line35>
> >
> >     there seems to be some inconsistency on how these signal handler bodies are done. Some seem to be single lines, no brackets, some seem to be multiline (ut single statement) with brackets.

coding style says: one line without brackets for single statement, otherwise brackets 


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111482/#review35992
-----------------------------------------------------------


On July 15, 2013, 6:22 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111482/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 6:22 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Initializes the pagebased layout. We can do this now because master does not need to be in a releasable state. But I could also do this in a feature branch.
> 
> Adds a FolderPage
> This page is just reusing AkonadiBreadcrumbNavigationView and a placeholder for the FavoriteFolder Page and the Accounts Page.
> For now there is a stupid Next-button to get to the next page. it will obviously go away once we have the actual FavoriteFolder page.
> 
> Adds a MailListPage
> We will need to merge MailListPage and HeaderView so we can push the MailViewPage form the list and not with the stupid button on the toolbar.
> 
> The MailListPage will only display a blank page for now. Will get fixed  when we merge MailListPage with HeaderView.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/AboutPage.qml b7e460e 
>   mobile/mail/AccountSettingsPage.qml 3cef3bf 
>   mobile/mail/CMakeLists.txt b56a722 
>   mobile/mail/FavoriteManagerPage.qml f83c6cd 
>   mobile/mail/FilterEditor.qml 95a6eb8 
>   mobile/mail/FolderPage.qml PRE-CREATION 
>   mobile/mail/ForwardOptionsPage.qml 887d501 
>   mobile/mail/HeaderView.qml ca94fa8 
>   mobile/mail/KMailActions.qml ee14d06 
>   mobile/mail/MailListPage.qml PRE-CREATION 
>   mobile/mail/MailViewPage.qml 0d6acb7 
>   mobile/mail/MarkAsPage.qml bcf35e9 
>   mobile/mail/NewMailPage.qml 13ed36e 
>   mobile/mail/ReplyOptionsPage.qml bb54bee 
>   mobile/mail/SettingsPage.qml 957076a 
>   mobile/mail/StartPage.qml 39d0291 
>   mobile/mail/kmail-mobile.qml 1eba3ec 
> 
> Diff: http://git.reviewboard.kde.org/r/111482/diff/
> 
> 
> Testing
> -------
> 
> selected a folder, selected an email, hit "reply button" and got the right text quoted in the composer
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/