[Kde-pim] Review Request 111642: kmail-mobile: blukactions for the MailListPage

[Kevin Krammer]

> On July 23, 2013, 12:21 p.m., Kevin Krammer wrote:
> > mobile/mail/MailListPage.qml, line 53
> > <http://git.reviewboard.kde.org/r/111642/diff/2/?file=173026#file173026line53>
> >
> >     wouldn't it be more consistent using the same approach as in review 111638?
> 
> Michael Bohlender wrote:
>     this action comes from akonadi/kmime/standardmailactionmanager.cpp and not from kmail-mobile, right? How can i access it like in review 111638 ?
>     This is also related to https://git.reviewboard.kde.org/r/109247/. I was thinking about doing the same as in making the toolButton checked/unchecked.
>     
>

Ah, I see. Hmm.
I think if you need to access more than just the trigger() function, e.g. if you need to read values from the action, then this approach is OK.
I guess we'll have to deal with that when porting to Qt5 if we want to lose the QtWidget dependency.
Maybe we should have a controller object that has slots for all those operations and internally delegate to the KAction if needed.
Lets discuss this at our hangout tonight


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111642/#review36370
-----------------------------------------------------------


On July 23, 2013, 12:32 p.m., Michael Bohlender wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111642/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 12:32 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> add checkbox and model to delegate
> make delegate layout relational to label size. 
> 
> add tools to
> # mark unread/read
> # mark important/unimportant
> # move to trash
> all checked from the list
> 
> 
> Diffs
> -----
> 
>   mobile/mail/CMakeLists.txt 360c64e 
>   mobile/mail/MailListPage.qml df5897b 
>   mobile/mail/MarkAsPage.qml 1320b0b 
>   mobile/mail/StartPage.qml a59d187 
> 
> Diff: http://git.reviewboard.kde.org/r/111642/diff/
> 
> 
> Testing
> -------
> 
> used all three toolbuttons when:
> 
> one was checked
> multiple checked
> non was checked
> 
> 
> Thanks,
> 
> Michael Bohlender
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/