[Kde-pim] Review Request 111515: Akonotes plasmoid: Explicitely set the text color to black

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111515/#review35994
-----------------------------------------------------------

Ship it!


Ship it.
Commit in 4.11 and we will merge in master (don't apply patch in master + 4.11 just 4.11)
Thanks

- Laurent Montel


On July 15, 2013, 5:26 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111515/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 5:26 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The akonotes plasmoid provided by KJots has a yellow background (provided by an svg image) but takes the text color from the current plasma theme.
> This results in unreadable notes when you are using a (dark) theme with a bright text color, e.g. Slim Glow or Produkt.
> 
> This patch fixes this by simply setting the text color to black.
> 
> 
> This addresses bug 263816.
>     http://bugs.kde.org/show_bug.cgi?id=263816
> 
> 
> Diffs
> -----
> 
>   kjots/plasmoid/akonotes_noteapplet.cpp e820960 
> 
> Diff: http://git.reviewboard.kde.org/r/111515/diff/
> 
> 
> Testing
> -------
> 
> Set plasma theme to Slim Glow and created a new akonote plasmoid on desktop. Text was still readable.
> 
> 
> File Attachments
> ----------------
> 
> Akonotes plasmoid in Slim Glow theme without this patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/15/akonotes_without_patch.png
> Akonotes plasmoid in Slim Glow theme with this patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/15/akonotes_with_patch.png
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/