[Kde-pim] Review Request 111458: kmail-mobile: rework headerlist

Michael Bohlender michael.bohlender at kdemail.net
Wed Jul 10 08:16:58 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111458/
-----------------------------------------------------------

(Updated July 10, 2013, 7:16 a.m.)


Review request for KDEPIM.


Changes
-------

remove missed bulkaction stuff.

better name for delegate id


Description
-------

Port headerlist away from KPIM.ItemList(delegate). This is necessary to make it a standalone page that can push other pages.
Port headerlist to plasmacomponents. (only what is needed stays)
Removes BulkActionComponent.
Removes headerlist configuration options.

The mail status icons get removed for now. the will probably by replaced by a single mailstatus icon/button. needs some changing in the proxymodel first.
The idea is to give the model an entry "mailStatus" that contains the status as an icon name (new/unread/read/important/replied/forwarded...) Is that a good approach? We will probably keep the old attachmethey are currently not working though. nt/signed/encrypted status icons.


Diffs (updated)
-----

  mobile/mail/BulkActionComponent.qml 748f80d 
  mobile/mail/CMakeLists.txt d4ea54b 
  mobile/mail/HeaderView.qml 9aab53e 
  mobile/mail/KMailActions.qml a146031 
  mobile/mail/StartPage.qml 9df5092 
  mobile/mail/configwidget.cpp 82e3490 
  mobile/mail/configwidget.ui 955a48a 

Diff: http://git.reviewboard.kde.org/r/111458/diff/


Testing
-------


Thanks,

Michael Bohlender

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list