[Kde-pim] Review Request 108378: Fix NepomukFeeder crash when Akonadi is empty

Allen Winter winter at kde.org
Sun Jan 13 17:15:42 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108378/#review25390
-----------------------------------------------------------

Ship it!


seems obvious enough. also this might fix bug https://bugs.kde.org/show_bug.cgi?id=313194

- Allen Winter


On Jan. 13, 2013, 12:37 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108378/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 12:37 a.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> When there are no items in Akonadi, there are no collections to fetch. However Akonadi::CollectionFetchJob() asserts when constructed with an empty collection list.
> 
> This regression was introduced in commit 1b2444.
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/nepomukfeederagent.cpp 6159015 
> 
> Diff: http://git.reviewboard.kde.org/r/108378/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list