[Kde-pim] Review Request: Merge akonadi-facebook into kdepim-runtime

[Kevin Krammer]

> On Oct. 24, 2012, 2:57 p.m., Kevin Krammer wrote:
> > resources/facebook/facebookresource_posts.cpp, line 114
> > <http://git.reviewboard.kde.org/r/107021/diff/1/?file=92164#file92164line114>
> >
> >     why not just in the if block in line 135?
> 
> Martin Klapetek wrote:
>     Because if there are no comments, it shows just "Likes: N", if I'd move it, it would be ", Likes: N". Either place I move it, it would have to have either check for commentsCount or check for likesCount.
> 
> Kevin Krammer wrote:
>     Ah, of course. I am wondering if we might not three strings, i.e. one for Comments+Likes with two arguments, one for just Comments and one for just Likes. Usually the translators want usto avoid string concatenation
> 
> Martin Klapetek wrote:
>     Yeah, I know it's wrong. But these are two unrelated words and their translation shouldn't really change if putted as separate strings (like now) or one string like i18n("Comments: %1, Likes: %1",...).

the words might be the same but e.g. the separator could be something else then ", "
I remember one instance a couple of years back when a translator (Japanese IIRC) said that markup like <b>important</b> didn't make sense in the target script, but that <em>important</em> could be solved by using a different symbol/word that means the same thing conceptually but is considered stronger


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107021/#review20791
-----------------------------------------------------------


On Jan. 2, 2013, 2:36 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107021/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 2:36 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patches adds akonadi-facebook resource into kdepim-runtime. It depends on LibKFacebook, which is currently at [1] and a sysadmin request has been filed to move it to playground.
> 
> [1] - kde:scratch/mklapetek/libkfacebook - http://quickgit.kde.org/index.php?p=scratch%2Fmklapetek%2Flibkfacebook.git&a=summary
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9005c7f 
>   resources/CMakeLists.txt 4288883 
>   resources/facebook/CMakeLists.txt PRE-CREATION 
>   resources/facebook/Info.plist.template PRE-CREATION 
>   resources/facebook/Messages.sh PRE-CREATION 
>   resources/facebook/facebookresource.cpp PRE-CREATION 
>   resources/facebook/facebookresource.desktop PRE-CREATION 
>   resources/facebook/facebookresource.h PRE-CREATION 
>   resources/facebook/facebookresource_events.cpp PRE-CREATION 
>   resources/facebook/facebookresource_friends.cpp PRE-CREATION 
>   resources/facebook/facebookresource_notes.cpp PRE-CREATION 
>   resources/facebook/facebookresource_notifications.cpp PRE-CREATION 
>   resources/facebook/facebookresource_posts.cpp PRE-CREATION 
>   resources/facebook/icons/CMakeLists.txt PRE-CREATION 
>   resources/facebook/icons/hi16-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi22-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi32-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi48-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hisc-apps-facebookresource.sgvz PRE-CREATION 
>   resources/facebook/serializer/CMakeLists.txt PRE-CREATION 
>   resources/facebook/serializer/akonadi_serializer_socialnotification.cpp PRE-CREATION 
>   resources/facebook/serializer/akonadi_serializer_socialnotification.desktop PRE-CREATION 
>   resources/facebook/serializer/akonadi_serializer_socialnotification.h PRE-CREATION 
>   resources/facebook/serializer/x-vnd.akonadi.socialnotification.xml PRE-CREATION 
>   resources/facebook/settings.h PRE-CREATION 
>   resources/facebook/settings.cpp PRE-CREATION 
>   resources/facebook/settingsbase.kcfg PRE-CREATION 
>   resources/facebook/settingsbase.kcfgc PRE-CREATION 
>   resources/facebook/settingsdialog.h PRE-CREATION 
>   resources/facebook/settingsdialog.cpp PRE-CREATION 
>   resources/facebook/settingsdialog.ui PRE-CREATION 
>   resources/facebook/timestampattribute.h PRE-CREATION 
>   resources/facebook/timestampattribute.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107021/diff/
> 
> 
> Testing
> -------
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/