[Kde-pim] Review Request 108665: Add 'Add New Tag...' action to Message->Mark Message menu

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108665/
-----------------------------------------------------------

(Updated Jan. 30, 2013, 1:50 p.m.)


Review request for KDEPIM and Laurent Montel.


Description
-------

This patch adds 'Add New Tag...' action to 'Message'->'Mark Message' menu in KMail. Otherwise there's no other way to create a new tag in KMail (I had to tag a random file in Dolphin so that the tag would appear in KMail and I could use it to tag my emails).

The patch also ensures that selected items are preserved when a tag is added/changed/removed. The tag actions are checked only when a message is selected, but when you select a message which already has a tag, create a new tag in Dolphin, then right-click the message in KMail, it will not have any tags checked, because clearActions(); createActions(); has recreated all KActions (thus all items are unchecked), but selection has not changed (thus the actions were not checked).

Now the URIs of checked tags are stored before calling clearActions() and restored after createActions() call.


Diffs (updated)
-----

  kmail/tagactionmanager.h 57535f9 
  kmail/tagactionmanager.cpp f6ee098 

Diff: http://git.reviewboard.kde.org/r/108665/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/