[Kde-pim] Review Request 108645: Replace the two overloads of KMail::Util::handleClickedURL() with a single function

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108645/#review26351
-----------------------------------------------------------


This review has been submitted with commit ef47d5e0b64ffb1ac7f6ed15e036ebe84066c817 by Jonathan Marten to branch master.

- Commit Hook


On Jan. 28, 2013, 4:38 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108645/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 4:38 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> While looking at the mailing list operations I noticed that there are two almost-identical overloaded functions in kmail/util.cpp:
> 
> void KMail::Util::handleClickedURL( const KUrl &url, const QSharedPointer<MailCommon::FolderCollection> &folder )
> void KMail::Util::handleClickedURL( const KUrl &url )
> 
> They could be replaced by a single function with a default parameter, reducing code duplication.  Since this source file is only used by KMail there should be no shared use or BC/SC issues.
> 
> 
> Diffs
> -----
> 
>   kmail/util.h 72df7dd 
>   kmail/util.cpp 39e3a81 
> 
> Diff: http://git.reviewboard.kde.org/r/108645/diff/
> 
> 
> Testing
> -------
> 
> Built kdepim with this change.  Checked operation of mailto: URLs and the mailing list "Invoke Handler" button.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/