[Kde-pim] Review Request 108447: Merge "Assign Folder Shortcut" into "Folder Properties"

[Jonathan Marten]

> On Jan. 18, 2013, 6:37 a.m., Laurent Montel wrote:
> > kmail/collectionshortcutpage.cpp, line 93
> > <http://git.reviewboard.kde.org/r/108447/diff/3/?file=107605#file107605line93>
> >
> >     in if (mShortcutChanged) no ?
> >     
> >     After that ship it.
> >     
> >     Thanks
> >     Regards.

Moved inside the conditional.  Decided not to merge the two conditions into one (mFolder && mShortcutChanged) because they are not in any way related.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108447/#review25741
-----------------------------------------------------------


On Jan. 17, 2013, 7:26 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108447/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 7:26 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This change merges the separate "Assign Shortcut" dialogue into a tab of "Folder Properties".
> 
> In order to maintain the same user experience, the actions and menu structure remain unchanged.  The "Assign Shortcut" option in the "Folder" menu and the folder context menu opens the "Folder Properties" dialogue at the appropriate tab.
> 
> The file that managed the dialogue (now the tab) is mostly unchanged, just renamed and with the corresponding class name changed.  Reviewboard doesn't detect that, hence the big diff.
> 
> 
> This addresses bug 115611.
>     http://bugs.kde.org/show_bug.cgi?id=115611
> 
> 
> Diffs
> -----
> 
>   kmail/CMakeLists.txt 83703bd 
>   kmail/collectionshortcutpage.h PRE-CREATION 
>   kmail/collectionshortcutpage.cpp PRE-CREATION 
>   kmail/foldershortcutdialog.h a78d5f6 
>   kmail/foldershortcutdialog.cpp a21a83e 
>   kmail/kmmainwidget.cpp 58973ff 
> 
> Diff: http://git.reviewboard.kde.org/r/108447/diff/
> 
> 
> Testing
> -------
> 
> Built kdepim with this change, checked operation of dialogue and assigned shortcut functions.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/