[Kde-pim] Review Request: Close AttachmentMissingWarning after attach file

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107916/#review24565
-----------------------------------------------------------

Ship it!


Seems good for me.
Ship it.
Commit in 4.10
I will merge in master.
Thanks.
If you can't commit will do it for you.

- Laurent Montel


On Jan. 2, 2013, 11:10 p.m., Torsten Grote wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107916/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 11:10 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Currently, the AttachmentMissingWarning at the bottom of the compose window is only closed when attaching a file with its own button, but not when attaching files by other means. I made showAddAttachmentDialog() emit a fileAttached() signal which in turn deactivates the warning. Maybe there is a better place to emit this signal e.g. when a file has successfully been attached.
> 
> 
> Diffs
> -----
> 
>   kmail/attachmentmissingwarning.h 37db948147ddb261e78cda0d98c694a550f4e665 
>   kmail/attachmentmissingwarning.cpp 0cf480dc5c307298035ce687fb41f586cf2d5fcc 
>   kmail/kmcomposewin.cpp 1306c2b9ada644824e5a505d7c199d69506f9d74 
>   messagecomposer/attachmentcontrollerbase.h 3c15c66700c7227e1bebd546ec1d3e11ec01d973 
>   messagecomposer/attachmentcontrollerbase.cpp 68253e74a24074a012423940a25bc73b4a3c8941 
> 
> Diff: http://git.reviewboard.kde.org/r/107916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten Grote
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/