[Kde-pim] Review Request 107482: ktimetracker tray icon doesn't connect to right signals

[Chuso Perez]

> On Dec. 24, 2012, 4:14 p.m., Allen Winter wrote:
> > You can ship it. remove the unnecessary include as Laurent pointed out.
> > Do you have a commit account or do you need someone to commit for you?

Include removed.
No, I don't have a commiter account.


- Chuso


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107482/#review23962
-----------------------------------------------------------


On Jan. 3, 2013, 3:12 p.m., Chuso Perez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107482/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 3:12 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> MainWindow tries to connect TrayIcon slots to some signals sent by TimetrackerWidget. But these signals are not being emitted by TimetrackerWidget, they are being emitted by TaskView.
> This code patches TimetrackerWidget to receive those TaskView signals and propagate them so MainWindow can receive them to connect them to TrayIcon.
> 
> 
> This addresses bug 289009.
>     http://bugs.kde.org/show_bug.cgi?id=289009
> 
> 
> Diffs
> -----
> 
>   timetrackerwidget.cpp f2d1d7a 
> 
> Diff: http://git.reviewboard.kde.org/r/107482/diff/
> 
> 
> Testing
> -------
> 
> Those methods from TrayIcon that are expected to be run when the signal is sent (change tray icon and update tool tip) are finally run (they are not being run until now, see bug).
> 
> 
> Thanks,
> 
> Chuso Perez
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/