[Kde-pim] Review Request 108549: Delay akonadi and nepomuk lookups to compress them.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108549/#review26005
-----------------------------------------------------------

Ship it!


Looks good to me.


libkdepim/addresseelineedit.cpp
<http://git.reviewboard.kde.org/r/108549/#comment19837>

    Forgot to say that the return should be on its own line, IMHO.


- David Faure


On Jan. 22, 2013, 7:07 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108549/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 7:07 p.m.)
> 
> 
> Review request for KDEPIM, David Faure and Tobias Koenig.
> 
> 
> Description
> -------
> 
> Delay akonadi and nepomuk lookups to compress them.
> 
> Introduce a per-addresseelineedit timer that delays completion
> lookups via both akonadi and nepomuk directly by 500ms, so they
> can be compressed. This avoids running too many queries when one types
> quickly into an addresseelineedit, which helps with performance.
> 
> 
> Diffs
> -----
> 
>   libkdepim/addresseelineedit.h a195d855704d78bbd4cfdb20807802c49655846c 
>   libkdepim/addresseelineedit.cpp 188470a8c1d1d78422917f39dc03f40e346cc7ef 
> 
> Diff: http://git.reviewboard.kde.org/r/108549/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Adam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/