[Kde-pim] Review Request 108554: Use a faster contains expression for "start of word" matches.

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108554/#review25999
-----------------------------------------------------------

Ship it!


Go for it!

- Vishesh Handa


On Jan. 22, 2013, 5:38 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108554/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 5:38 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, David Faure, Tobias Koenig, and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Use a faster contains expression for "start of word" matches.
> 
> For the special case of address completion, we are really only
> interested in matching at the start of various parts of the name, first
> name, email, etc. So for that case, use bif:contains('foo*') rather than
> the much more expensive regexp match. Speeds up addressee completion
> something fierce for a minor loss in functionality, namely arbitrary
> substring matching.
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactsearchjob.cpp 7b71b07a721b83efc0e411dd8e57cb4991b10a14 
> 
> Diff: http://git.reviewboard.kde.org/r/108554/diff/
> 
> 
> Testing
> -------
> 
> Address completion in KMail is flying with this ;).
> 
> 
> Thanks,
> 
> Till Adam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/