[Kde-pim] Review Request: In akonadi_nepomuk_feeder don't ignore collection containing email if reindexing was enforced by the user

Christian Mollekopf chrigi_1 at fastmail.fm
Sun Jan 6 15:28:29 GMT 2013



> On Jan. 6, 2013, 3:28 p.m., Christian Mollekopf wrote:
> > Ship It!

To 4.10 please. Thanks for the patch.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108229/#review24835
-----------------------------------------------------------


On Jan. 6, 2013, 3:19 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108229/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 3:19 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> The nepomuk feeder does not index collections containing emails during inital indexing. It should index collections containing emails if the user enforces the indexing by pressing the "Enforce reindexing" button in KMail2 but it does not do so. There is a FIXME in the code which mentions this.
> 
> This patch corrects the feeder's behavior.
> 
> I added cmollekopf to reviewers because he introduced the FIXME line.
> 
> 
> Diffs
> -----
> 
>   agents/nepomukfeeder/nepomukfeederagent.h 5b652e1 
>   agents/nepomukfeeder/nepomukfeederagent.cpp 7e50f82 
> 
> Diff: http://git.reviewboard.kde.org/r/108229/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Jan Gerrit Marker
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list