[Kde-pim] Review Request: Merge akonadi-facebook into kdepim-runtime

[Martin Klapetek]

> On Jan. 6, 2013, 2:12 p.m., Kevin Krammer wrote:
> > resources/facebook/facebookresource_posts.cpp, line 115
> > <http://git.reviewboard.kde.org/r/107021/diff/8-9/?file=103822#file103822line115>
> >
> >     I would make this the first case of the if, i.e. first "then" part handles comments+likes, then just comment and then just likes
> >     
> >     also reduces the conditions of the second two cases because we then already know that one or both of the variables are 0
> >     
> >     if ( comments > 0 && likes > 0 )
> >     else if ( comments > 0 )
> >     else if ( likes > 0 )
> >

On the other hand I think the present "&& likes == 0".. makes the code better readable as the reader immediately knows what's going on in there


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107021/#review24821
-----------------------------------------------------------


On Jan. 6, 2013, 1:21 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107021/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 1:21 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This patches adds akonadi-facebook resource into kdepim-runtime. It depends on LibKFacebook, which is currently at [1] and a sysadmin request has been filed to move it to playground.
> 
> [1] - kde:scratch/mklapetek/libkfacebook - http://quickgit.kde.org/index.php?p=scratch%2Fmklapetek%2Flibkfacebook.git&a=summary
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9005c7f 
>   resources/CMakeLists.txt 4288883 
>   resources/facebook/CMakeLists.txt PRE-CREATION 
>   resources/facebook/Info.plist.template PRE-CREATION 
>   resources/facebook/Messages.sh PRE-CREATION 
>   resources/facebook/facebookresource.cpp PRE-CREATION 
>   resources/facebook/facebookresource.desktop PRE-CREATION 
>   resources/facebook/facebookresource.h PRE-CREATION 
>   resources/facebook/facebookresource_events.cpp PRE-CREATION 
>   resources/facebook/facebookresource_friends.cpp PRE-CREATION 
>   resources/facebook/facebookresource_notes.cpp PRE-CREATION 
>   resources/facebook/facebookresource_notifications.cpp PRE-CREATION 
>   resources/facebook/facebookresource_posts.cpp PRE-CREATION 
>   resources/facebook/icons/CMakeLists.txt PRE-CREATION 
>   resources/facebook/icons/hi16-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi22-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi32-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hi48-apps-facebookresource.png PRE-CREATION 
>   resources/facebook/icons/hisc-apps-facebookresource.sgvz PRE-CREATION 
>   resources/facebook/serializer/CMakeLists.txt PRE-CREATION 
>   resources/facebook/serializer/akonadi_serializer_socialnotification.cpp PRE-CREATION 
>   resources/facebook/serializer/akonadi_serializer_socialnotification.desktop PRE-CREATION 
>   resources/facebook/serializer/akonadi_serializer_socialnotification.h PRE-CREATION 
>   resources/facebook/serializer/x-vnd.akonadi.socialnotification.xml PRE-CREATION 
>   resources/facebook/settings.h PRE-CREATION 
>   resources/facebook/settings.cpp PRE-CREATION 
>   resources/facebook/settingsbase.kcfg PRE-CREATION 
>   resources/facebook/settingsbase.kcfgc PRE-CREATION 
>   resources/facebook/settingsdialog.h PRE-CREATION 
>   resources/facebook/settingsdialog.cpp PRE-CREATION 
>   resources/facebook/settingsdialog.ui PRE-CREATION 
>   resources/facebook/timestampattribute.h PRE-CREATION 
>   resources/facebook/timestampattribute.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107021/diff/
> 
> 
> Testing
> -------
> 
> Builds fine.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/