[Kde-pim] Review Request 108254: Don't add line breaks into URLs

[Laurent Montel]

> On Jan. 14, 2013, 12:36 p.m., Laurent Montel wrote:
> > kpimtextedit/textedit.cpp, line 385
> > <http://git.reviewboard.kde.org/r/108254/diff/2/?file=107050#file107050line385>
> >
> >     just https ? not http ? ftp ? etc ?
> 
> Kevin Krammer wrote:
>     http is covered, the '?' makes the 's' optional
> 
> Torsten Grote wrote:
>     This regexp currently works for http and https where this problem is most pressing. I don't know if other protocols usually have URLs with dashes in them. What other protocol identifiers do you think I should add?

ftp/ftps for example. ldap perhaps.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108254/#review25446
-----------------------------------------------------------


On Jan. 13, 2013, 1:09 p.m., Torsten Grote wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108254/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 1:09 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> When using word wrap at a fixed column in KMail (e.g.), there is the annoying behavior that long URLs with dashes (that are very common nowadays) are broken into two or more lines, making it impossible for receivers of emails to just click the URL. This patch prevents that a forced line break is inserted into a URL.
> 
> Note that this patch does not prevent the URL to be visually broken while editing. It just does not add a forced line break in URLs upon sending or saving of the text.
> 
> 
> Diffs
> -----
> 
>   kpimtextedit/tests/textedittest.h c961f9b6aa5d9de94972ecad9dde81ac9c14cb61 
>   kpimtextedit/tests/textedittest.cpp 8f9277820a44ed1084da8a292a34350eac73a60a 
>   kpimtextedit/textedit.cpp aaa546484027a26ece7ec2f322f383217cf14922 
> 
> Diff: http://git.reviewboard.kde.org/r/108254/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Torsten Grote
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/