[Kde-pim] Review Request: FIX LIBRARY API DOCUMENTATION Errors: Fix #4

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108087/#review24438
-----------------------------------------------------------



kimap/setacljob.h
<http://git.reviewboard.kde.org/r/108087/#comment18715>

    Move that to the end of the documentation block, i.e. after
    user "fred" will not have the 'w' right.



kimap/setquotajob.h
<http://git.reviewboard.kde.org/r/108087/#comment18716>

    move to before @see line, keeping an empty line between the note text and the @param line



kioslave/imap4/imap4.h
<http://git.reviewboard.kde.org/r/108087/#comment18717>

    move to end of comment block



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18718>

    I think parent here is just the QWidget parent
    @param parent the QWidget parent



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18719>

    remove trailng whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18720>

    @param user the user name to set



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18722>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18723>

    typo: bn -> dn
    or better DN



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18724>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18725>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18726>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18727>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18728>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18729>

    remove trailing whitespace



kldap/ldapconfigwidget.h
<http://git.reviewboard.kde.org/r/108087/#comment18730>

    remove trailing whitespace



kldap/ldapconnection.h
<http://git.reviewboard.kde.org/r/108087/#comment18731>

    @param url the URL containing the connection parameters



kldap/ldapconnection.h
<http://git.reviewboard.kde.org/r/108087/#comment18733>

    server the server object containing the connection parameters



kldap/ldapconnection.h
<http://git.reviewboard.kde.org/r/108087/#comment18734>

    remove trailing whitespace



kldap/ldapconnection.h
<http://git.reviewboard.kde.org/r/108087/#comment18735>

    remove trailing whitespace



kldap/ldapconnection.h
<http://git.reviewboard.kde.org/r/108087/#comment18736>

    remove trailing whitespace



kldap/ldapcontrol.h
<http://git.reviewboard.kde.org/r/108087/#comment18737>

    I think this is singular here (LdapControl not LdapControls)
    @param ctrl the control to insert



kldap/ldapmodel.h
<http://git.reviewboard.kde.org/r/108087/#comment18738>

    I guess this is just the QObject parent
    @param parent the parent QObject



kldap/ldapmodel.h
<http://git.reviewboard.kde.org/r/108087/#comment18739>

    see above



kldap/ldapobject.h
<http://git.reviewboard.kde.org/r/108087/#comment18740>

    @param attributeName the attribute name for which to set values



kldap/ldapobject.h
<http://git.reviewboard.kde.org/r/108087/#comment18741>

    @param attributeName the attribute for which to add a value



kmbox/mbox.h
<http://git.reviewboard.kde.org/r/108087/#comment18742>

    @param deletedEntries list of mbox entries that have been deleted and need not be retrieved



kmime/kmime_content.h
<http://git.reviewboard.kde.org/r/108087/#comment18743>

    @param frozen freeze content if @c true, otherwise unfreeze



kmime/kmime_content.h
<http://git.reviewboard.kde.org/r/108087/#comment18744>

    @param type the header type to find



kmime/kmime_content.h
<http://git.reviewboard.kde.org/r/108087/#comment18745>

    @param type the header type to find



kmime/kmime_content.h
<http://git.reviewboard.kde.org/r/108087/#comment18746>

    @param name the header type to find


- Kevin Krammer


On Jan. 2, 2013, 3:05 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108087/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 3:05 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> FIX LIBRARY API DOCUMENTATION Errors: Fix #4
> 
> 
> Diffs
> -----
> 
>   kimap/setacljob.h 0cc07dd 
>   kimap/setquotajob.h f3fac37 
>   kioslave/imap4/imap4.h a3e1f9d 
>   kioslave/nntp/nntp.h d245918 
>   kldap/ldapconfigwidget.h d871410 
>   kldap/ldapconnection.h 88c50a2 
>   kldap/ldapcontrol.h a4d5731 
>   kldap/ldapmodel.h 6efbd80 
>   kldap/ldapobject.h cba01c7 
>   kldap/ldapoperation.h 233deee 
>   kldap/ldapsearch.h 989a5ba 
>   kldap/ldapserver.h 3694b70 
>   kldap/ldif.h f732c9d 
>   kmbox/mbox.h 7b24867 
>   kmime/kmime_content.h 7cbe19e 
> 
> Diff: http://git.reviewboard.kde.org/r/108087/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/