[Kde-pim] Review Request 108545: Kmail Mobile: remove separate expiry properties dialogue

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108545/#review26136
-----------------------------------------------------------

Ship it!


- Allen Winter


On Jan. 22, 2013, 12:37 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108545/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 12:37 p.m.)
> 
> 
> Review request for KDEPIM and Allen Winter.
> 
> 
> Description
> -------
> 
> Review 108485 removed the separate "Expiry Properties" dialogue (but not the actions) from KMail desktop, and added it as a tab of the standard "Folder Properties" dialogue.  This needs to be done for KMail Mobile also, as the header file and dialogue no longer exists.
> 
> See http://lists.kde.org/?t=135869252400001&r=1&w=2 for discussion on the chosen option.
> 
> 
> Diffs
> -----
> 
>   mobile/mail/KMailActions.qml 5fb238a 
>   mobile/mail/mailactionmanager.cpp 9490710 
>   mobile/mail/mainview.h 8c22527 
>   mobile/mail/mainview.cpp ad2e2e9 
> 
> Diff: http://git.reviewboard.kde.org/r/108545/diff/
> 
> 
> Testing
> -------
> 
> Built kmail-mobile with these changes, checked actions and operation of the properties dialogue.  Not able to test on any touch hardware, though.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/