[Kde-pim] Review Request 108719: kaddressbook: better layout for action icons next to entries

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108719/#review26616
-----------------------------------------------------------


This review has been submitted with commit d9848c1fb3af47dc4ecb5adab0c939efc4b69da8 by Jonathan Marten to branch master.

- Commit Hook


On Feb. 2, 2013, 4:51 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108719/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2013, 4:51 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Some address book entries (e.g. the address) place an action icon next to the data, to be clicked on to perform some appropriate action.  Currently these are placed immediately after the text with no special formatting or spacing, so they are squashed up to it and are not aligned with any others.
> 
> This change places the icons in a separate HTML table column so that they are vertically aligned, and top-aligned with the first line of the data.  The SMS link for a mobile telephone number is changed to an icon to demonstrate this.
> 
> I have plans to add more action icons (e.g. in order to be able to display and start with a click all of the supported IM entries), so this is the foundation to allow that to be done.
>  
> Blank lines in the address display are squashed, as originally submitted on https://svn.reviewboard.kde.org/r/5912/
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactviewer.cpp ed4d103 
>   akonadi/contact/standardcontactformatter.cpp ed605a4 
> 
> Diff: http://git.reviewboard.kde.org/r/108719/diff/
> 
> 
> Testing
> -------
> 
> Built kdepimlibs and kaddressbook with this change.  Checked display of my contacts and operation of the action icons. Checked that all table layout columns are accounted for by temporarily enabling borders.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/kaddressbook-tablelayout_before.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/02/kaddressbook-tablelayout_after.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/