[Kde-pim] Review Request 109208: Work harder to ensure we have a trash folder

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109208/
-----------------------------------------------------------

(Updated Feb. 28, 2013, 4:45 p.m.)


Review request for KDEPIM.


Changes
-------

the patch was too complicated.


Description
-------

collection.isValid() is not enough, collection might have a negative id and no remoteId


This addresses bugs 285532, 303117 and 307016.
    http://bugs.kde.org/show_bug.cgi?id=285532
    http://bugs.kde.org/show_bug.cgi?id=303117
    http://bugs.kde.org/show_bug.cgi?id=307016


Diffs (updated)
-----

  akonadi/specialcollectionsrequestjob.cpp 29db72f0e3bc60b0f8b9c9434151176bea44b14f 

Diff: http://git.reviewboard.kde.org/r/109208/diff/


Testing
-------

removed all .local/share/akonadi* and restarted kmail. Without patch, no trash. With patch, trash is generated.


Thanks,

Wolfgang Rohdewald

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/