[Kde-pim] Review Request 108961: Fix for address autocompletion of addressbook contacts

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108961/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

This patch fixes displaying of contacts found in the addressbook, for the case where the query going directly to nepomuk returns before the query going through akonadi (the one which looks for addressbook contacts).
    
completion->allMatches doesn't provide all the necessary search results, resulting in at least some cases in some search results not being displayed.
completions->substringCompletion on the other hand always provides the right results.
I'm not sure why the code is that complex (not sure what problem it's trying to solve), nor if anything else breaks with that change, but I don't think so.

I'll have to look on it again to figure out why exactly it wasn't working before, and why this patch fixes it, so if anyone more experienced with that codebase wants to look into it I wouldn't mind ;-)


Diffs
-----

  libkdepim/addresseelineedit.cpp 80bab8424412371ac39980ab9408e92a084bd175 

Diff: http://git.reviewboard.kde.org/r/108961/diff/


Testing
-------

Works for me.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/