[Kde-pim] Review Request 108810: Modify the content of mMaildirsForCollection after a folder-move

[Wolfgang Rohdewald]

Am Sonntag, 10. Februar 2013, 17:24:47 schrieb Andras Mantia:
> 1) maildir-synctest: fails and hangs on exit

after working around that qdbus bug I mentioned, maildir-synctest passes but
still hangs on exit. I tried to find the reason but no success yet. And - I have
no idea if my qdbus change is correct or if it introduces other bugs. Maybe
if signal==0, disconnectNotify should act for all signals (just like QObject::disconnect
does) instead of doing nothing


wr at kdedev:~/kdesrc/qt$ git diff
diff --git a/src/dbus/qdbusabstractinterface.cpp b/src/dbus/qdbusabstractinterface.cpp
index 4b7a9cd..17b9b67 100644
--- a/src/dbus/qdbusabstractinterface.cpp
+++ b/src/dbus/qdbusabstractinterface.cpp
@@ -606,7 +606,8 @@ void QDBusAbstractInterface::disconnectNotify(const char *signal)
     Q_D(QDBusAbstractInterface);
     if (!d->isValid)
         return;
-
+    if (!signal)
+        return;
     QDBusConnectionPrivate *conn = d->connectionPrivate();
     if (conn)
         conn->disconnectRelay(d->service, d->path, d->interface,

-- 
Wolfgang
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/