[Kde-pim] Review Request 109186: work around a file descriptor leak when using QFileSystemWatcher

[Andras Mantia]

Laurent Montel wrote:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109186/#review28194
> -----------------------------------------------------------
> 
> 
> If KDirWatch leak fd, we must fix kdirwatch and not workaround no ?
> If it leaks it will leak in other kde components.
> 
> So for me we must to fix kdirwatch first

Yeah, we might need to fix the leak/report it. But what he did is sensible, 
that is public API and according to the API docs it is exactly there for the 
reason we use it: temporarly suspend watching of folders.

The old way I coded it (removeDir/addDir) is actually more hacky than the 
proposed one.

Andras
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/