[Kde-pim] mailfilter does not see all incoming messages

[Andras Mantia]

Wolfgang Rohdewald wrote:

> Am Dienstag, 26. Februar 2013, 14:52:00 schrieb Andras Mantia:
>> I hope my explanation made it clear why the default implementation has
>> the changeProcessed() in there (because the default behavior is to use a
>> real changerecorder, not a monitor).
> 
> could the default implementations check and only call changeProcessed()
> if recording is enabled?

In theory it could, but this is something we would need to discuss, as it 
changes the behavior, although the change should be harmless. I suggest to 
discuss this on the pim meeting in the weekend.

> that would make my patch unnecessary and maybe help for future agents
> without recording

Your patch is anyway necessary for 4.10 series (and 4.9 or others).
> 
> if not, should mailfilter override all possible slots with empty
> implementations? like itemMoved, itemRemoved, itemLinked, collectionAdded
> or whatever? Or is it granted that only itemAdded and itemChanged can get
> there?

It can happen also with those, i think. There is no guarantee what kind of 
methods are called in the agent.

Andras



_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/