[Kde-pim] Review Request 108837: kaddressbook: display and make clickable all IM addresses

Martin Klapetek martin.klapetek at gmail.com
Thu Feb 7 21:19:58 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108837/#review26873
-----------------------------------------------------------


Hey, adding some input from KDE Telepathy point of view. This unfortunately won't make it possible to start chats with KDE Telepathy. Starting any IM actions with KTp is little bit more complex, where one first needs to initialize the proper components (Telepathy's AccountManager) and then get an account identifier together with unique Telepathy contact identifier; only then one can start chats with KTp. Assuming the IM handle in KAddressBook is that Telepathy contact id, we'd still need the account id, which is usually in form like gabble/jabber/martin_2eklapetek_40gmail_2ecom0. 

We /could/ make a tiny app that loops through all Telepathy contacts and finds a match. But this will work only with connected accounts, otherwise Telepathy does not have a list of account's contacts. However handling Facebook/G+ IM contacts would be impossible as they have non-standard non-human readable contact ids, so we wouldn't find a match there either. 

Finally, this is solved with the shared metacontacts, where you basically connect your Akonadi account with Telepathy account through the means of Nepomuk and you can then start chats etc. I'll be presenting a working demo at the PIM sprint in 3 weeks :)

- Martin Klapetek


On Feb. 7, 2013, 5:58 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108837/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 5:58 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Currently the address book only displays the "set as standard" IM address, even if the contact has more than one, and it is not clickable so nothing can be done with the displayed information
> 
> This change displays all of the configured IM addresses, identifying the protocol/application that applies - see screen shot.  Clicking on the address or icon will emit a new signal messagingClicked() from the contact viewer, similar to the existing ones (urlClicked() etc), identifying the protocol and address.  With this in place in kdepimlibs, a configuration and GUI could be implemented in the application to start an IM program, run a command or do whatever else is appropriate.
> 
> This addition is BC (adding a new non-virtual function).
> 
> 
> Diffs
> -----
> 
>   akonadi/contact/contactviewer.h 2ef8802 
>   akonadi/contact/contactviewer.cpp 06fda94 
>   akonadi/contact/standardcontactformatter.cpp 7e28346 
> 
> Diff: http://git.reviewboard.kde.org/r/108837/diff/
> 
> 
> Testing
> -------
> 
> Built kdepimlibs and kaddressbook with this change.  Checked display of multiple IM addresses and that the signal is emitted when one is clicked.
> 
> 
> File Attachments
> ----------------
> 
> IM addresses display
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/07/kaddressbook-imdisplay.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list