[Kde-pim] Review Request 108974: Escape UIDs in resources that use them as filename

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108974/
-----------------------------------------------------------

(Updated Feb. 27, 2013, 3:39 p.m.)


Review request for KDEPIM.


Changes
-------

Use libmaildir UID generator to create unique filename and remoteId.

This patch does not include fix for the Dav resource, because I'm not familiar with it or the DAV RFCs. Any help is welcomed (we can look on it on the sprint).


Description
-------

Contacts, vcarddir, icaldir and dav resources use KABC::Addressee::uid() or KCalCore::Incidence::uid() as part of the destination filenames. This fails if the UID contains unsafe characters like path delimiter, colon etc.

This patch uses QUrl::toPercentEncoding() to make sure the UID is safe to use.


Diffs (updated)
-----

  resources/contacts/contactsresource.h ce92d6d 
  resources/contacts/contactsresource.cpp 499f56e 
  resources/icaldir/icaldirresource.h 8fe7733 
  resources/icaldir/icaldirresource.cpp d653220 
  resources/vcarddir/vcarddirresource.h 1423bdf 
  resources/vcarddir/vcarddirresource.cpp e5d5ded 

Diff: http://git.reviewboard.kde.org/r/108974/diff/


Testing
-------

Successfully copied a contact from akonadi_googlecontacts_resource (which uses full http:// URL as UID) to akonadi_contacts_resource (which uses ~/.local/contacts/%contactUID%.vcard as filename).


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/