[Kde-pim] Review Request 108779: create 1 - a more appropriate message, 2 - a message earlier

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108779/#review26647
-----------------------------------------------------------



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/108779/#comment20235>

    I'm not sure we (in KDE) translate debug/warning messages. If that is the policy I'm fin with the change though. The text change is ok from my side.



resources/maildir/maildirresource.cpp
<http://git.reviewboard.kde.org/r/108779/#comment20236>

    As this is a user visible message, I think it must be reformulated somehow.[*] What about
    "Folder %1, having the id %2 has empty remote identifier. Please run akonadictl fsck to fix the problem". 
    Assuming akonadictl fsck fixes it. ;)
    If not, it should tell what to do in order to fix it (ie. run Akonadiconsole, execute a query. Well, it could point to some userbase wiki page, as manual fixing is not exactly trivial).
    
    [*] I know many messages from here and the rest of Akonadi are cryptic to the end-user, but we should aim to fix those.


- Andras Mantia


On Feb. 4, 2013, 5:36 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108779/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2013, 5:36 p.m.)
> 
> 
> Review request for KDEPIM, Andras Mantia, Kevin Krammer, and Till Adam.
> 
> 
> Description
> -------
> 
> first, a more appropriate message at line 62.
> second, a message should be give much more earlier, at line 522.
> 
> 
> Diffs
> -----
> 
>   resources/maildir/maildirresource.cpp df989c1 
> 
> Diff: http://git.reviewboard.kde.org/r/108779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/