[Kde-pim] Review Request 108836: Show KPIM::ProgressItem when retrieving folder properties

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108836/#review26931
-----------------------------------------------------------

Ship it!


Didn't test this patch.
But seems good.
Commit please.
Ship it

- Laurent Montel


On Feb. 7, 2013, 5:27 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108836/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 5:27 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Show KPIM::ProgressItem while retrieving folder properties before showing the Folder Properties dialog itself.
> 
> When Akonadi is fetching new emails, all other Akonadi-based jobs are blocked. This means that when you try to open Folder Properties dialog, nothing happens because the CollectionAttributesSynchronizationJob is blocked. The suddenly some time later (when mail check is finished) the dialog pops up...or more dialogs, if user impatiently clicks the action multiple times while waiting.
> 
> This is not very user-friendly, so I added a KPIM::ProgressItem to show 'Retrieving folder properties' progress bar to at least indicate, that KMail is working on it.
> 
> (I originally wanted to add some kind of 'Loading...' label to the dialog, but since the dialog is in kdepimlibs, this will have to do :-)
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.h 575763c 
>   kmail/kmmainwidget.cpp f4a7867 
> 
> Diff: http://git.reviewboard.kde.org/r/108836/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/