[Kde-pim] Review Request 114304: MessageList ContentSummary: Port away from Nepomuk

[Christian Mollekopf]

> On Dec. 4, 2013, 5:49 p.m., Laurent Montel wrote:
> > This feature was usefull when we use tooltips on messagelist.
> > Without it we can remove this feature, because we need to fetch item => select it to have info.
> > But if we select it not necessary to have tooltips :)
> > For me it's a regression.
> > Regards
> >

If I understand you correctly, you're referring to the case where nepomuk has a cached copy of the payload, but akonadi has already dropped it's cache i.e. because it's online imap. In this scenario nepomuk allows to show a tooltip, although the payload is not available on the system.
While this may indeed look like a regression, the problem is much more efficiently solved by using offline imap (e.g. not dropping the cache in akonadi). Akonadi is IMO a more efficient cache than nepomuk, so we don't gain anything by downloading all data, copying it into nepomuk, and then dropping the copy from akonadi again.

So IMO the way to go for tooltips is to simply use an Akonadi::ItemFetchJob to retrieve the full payload.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114304/#review45118
-----------------------------------------------------------


On Dec. 4, 2013, 4:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114304/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 4:57 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
>     It makes very little sense to use Nepmuk to fetch the plain text content
>     of the email. Nepomuk is not meant to be a data store in the case of
>     Akonadi. Do not treat it like one.
>     
>     Instead we fetch the data from Akonadi instead.
>     
>     The function only works if the item has the complete payload.
> 
> 
> Diffs
> -----
> 
>   kmail/searchdialog/kmsearchmessagemodel.cpp dfe602c 
>   messagelist/core/view.cpp fa4dc46 
>   messagelist/messagelistutil.h 3ff5450 
>   messagelist/messagelistutil.cpp 4334a22 
> 
> Diff: http://git.reviewboard.kde.org/r/114304/diff/
> 
> 
> Testing
> -------
> 
> This currently does not work for the tooltips as the item does not have the complete payload. If this is something we can all agree on then maybe I can look into the code calling this to fetch the full payload.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/