[Kde-pim] Review Request 114174: Remove pointless check for loadedPayloadParts, that just introduces another way for things to fail.

Christian Mollekopf chrigi_1 at fastmail.fm
Mon Dec 2 08:59:54 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114174/
-----------------------------------------------------------

(Updated Dec. 2, 2013, 8:59 a.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries, Dan Vrátil and Volker Krause.


Repository: kdepimlibs


Description
-------

Remove pointless check for loadedPayloadParts, that just introduces another way for things to fail.

This fixes the failing gidmigration unittest, because the testserializer didn't implement parts().
This check is was without value anyways, since parts() required a serializer plugin lookup just like extractGid.

I'm not sure why this ever worked, but I'd like to commit this patch in any case as I think it's good to get rid of another magic way that gid extraction can fail.


Diffs
-----

  akonadi/gid/gidextractor.cpp c1590431453de80ab71166b880c6cd3de21e12fe 

Diff: http://git.reviewboard.kde.org/r/114174/diff/


Testing
-------

gidmigration test passes again.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list