[Kde-pim] Review Request 114140: Allow PreprocessorBase subclasses to specify fetch scope for each item

[Volker Krause]

> On Nov. 30, 2013, 4:41 p.m., Kevin Krammer wrote:
> > akonadi/preprocessorbase.h, line 172
> > <http://git.reviewboard.kde.org/r/114140/diff/1/?file=220159#file220159line172>
> >
> >     I am not sure you can do this:
> >     http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Add_new_virtuals_to_a_non-leaf_class

Yep, that's not BC. A possible workaround could be making this a Q_INVOKABLE or a slot, and calling it via QMetaObject in the implementation. This gives it virtual-like behavior, while being BC. Obviously something to clean up for KF5 then.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114140/#review44894
-----------------------------------------------------------


On Nov. 26, 2013, 1:46 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114140/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 1:46 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Without this, the MailFilter agent would have to fetch full scope every time, which is not the desired behavior (headers are enough usually).
> 
> To be able to do this, I've added this method, that is called every time before the ItemFetchJob in PreprocessorBase is invoked and allows subclasses to set a fetch scope depending on the parent collection.
> 
> 
> Diffs
> -----
> 
>   akonadi/preprocessorbase.h 94b967e 
>   akonadi/preprocessorbase.cpp 3f68cbb 
>   akonadi/preprocessorbase_p.cpp 3ebeb69 
> 
> Diff: http://git.reviewboard.kde.org/r/114140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/