[Kde-pim] Review Request 114357: Attempt to fix the CardDAV resource to parse multiple VEVENTs (with recurrence-ID set) in the returned ical correctly

[Martin Kyral]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114357/#review45388
-----------------------------------------------------------


The root cause of the leak seems to be this:

-      item.setPayload<IncidencePtr>( ptr );
+      foreach ( const IncidencePtr &incidence, incidences ) {
+        item.setMimeType ( incidence->mimeType() );
+        item.setRemoteId( incidence->instanceIdentifier() );
+        item.setPayload( IncidencePtr( incidence->clone() ) );

on every sync, I see zillions of "Modify Items akonadi_davgroupware_resource ... PLD:RFC822" in akonadiconsole (Notifications tab)

- Martin Kyral


On Dec. 9, 2013, 11:52 a.m., Martin Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114357/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 11:52 a.m.)
> 
> 
> Review request for Akonadi, KDEPIM and Sergio Luis Martins.
> 
> 
> Bugs: 284884
>     http://bugs.kde.org/show_bug.cgi?id=284884
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Continuing where review 113374 ended (https://git.reviewboard.kde.org/r/113374/). The patch is fixing the issues raised in the original review.
> However, it is incomplete and needs further work.
> 
> 
> Diffs
> -----
> 
>   resources/dav/resource/davgroupwareresource.cpp b8b2f74 
> 
> Diff: http://git.reviewboard.kde.org/r/114357/diff/
> 
> 
> Testing
> -------
> 
> The patch fixes the bug partially (recurring events are shown, but exceptions are missing).
> It seems that the patch causes serious memleak in korgac.
> 
> 
> Thanks,
> 
> Martin Kyral
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/