[Kde-pim] Review Request 114117: Port Mail Filter Agent to Akonadi::PreprocessorBase

[Dan Vrátil]

> On Nov. 26, 2013, 10:36 a.m., Dan Vrátil wrote:
> > Just came to the office this morning and got a batch of about 200 new mails. Although some were filtered immediately, some appeared in Inbox before being moved to their target folder, so it's not working 100% perfect :-) I don't know yet whether it's a problem in Akonadi or the Mail Filter.

Found out why the emails appear in KMail despite being marked as hidden in Akonadi.

The HIDDEN attribute is not part of FETCH response unless client explicitly requests it, so the filtering (check for HiddenAttribute) in ETM does not work. This should probably be fixed on Akonadi side to always include HIDDEN attribute in FETCH response, even when not explicitly requested. Other solution that would work is not to send notifications about hidden items, but that's a behaviour change that might theoretically break something.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114117/#review44482
-----------------------------------------------------------


On Nov. 26, 2013, 2:48 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114117/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 2:48 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When a new item is stored in Akonadi the server first runs it to chain of preprocessors and only after that it notifies regular clients.
> 
> By porting Mail Filter agent to be a preprocessor, filtering happens before the email reaches KMail. As a result, the emails are not piling in Inbox, and then slowly disappearing into their destination folders, but instead they appear in the correct folders right away.
> 
> 
> There was a bug in PreprocessorBase that prevented preprocessor from registering to D-Bus, which is fixed now. To test this patch, you need Akonadi and kdepimlibs from latest master.
> 
> 
> Diffs
> -----
> 
>   agents/mailfilteragent/filtermanager.h b95fc15 
>   agents/mailfilteragent/filtermanager.cpp a9b76f1 
>   agents/mailfilteragent/mailfilteragent.h c8ca7b4 
>   agents/mailfilteragent/mailfilteragent.cpp 5168cf0 
> 
> Diff: http://git.reviewboard.kde.org/r/114117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/